Hacks to core and point_mode to enable unit tests#151
Draft
djmallum wants to merge 2 commits intoChrismarsh:developfrom
Draft
Hacks to core and point_mode to enable unit tests#151djmallum wants to merge 2 commits intoChrismarsh:developfrom
djmallum wants to merge 2 commits intoChrismarsh:developfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The purpose of this PR is to start a discussion on point_mode runs in CHM without requiring a mesh. A future version of CHM could have an option to have something like this but not hacky.
Details
The following are changes I made to core.cpp and point_mode to allow the running of a single module within CHM but essentially separetely from it. Manually written mesher file allows fine grained parameter control without needed to deal with built in CHM mesh components.
Currently, to run point_mode one is required to specificy a point in space. In order words, one needs to have a full prepared CHM mesh. These changes allowed for a manually written mesher file and not having to worry about the "mesh" being at a valid grid point.
Takes the first face, and in a 0D (or 1D in the case of vertical processes) face(0) is the only triangle defined in the mesher file.
In point_mode, use of a user defined flag
unit_test_new_modulesallows for user defined, run specific depends and provides in the constructor and fetching from met files in the run function.Note
This point_mode version is made to run modules that don't yet exist in CHM but are in this PR draft.
I intend to include manual mesher file and config file to this PR in the future for clarity.